Bring in fips.h into pwdbased.h for FIPS v6+ - #11328
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the wolfCrypt password-based key derivation header to automatically pull in the FIPS interface for FIPS v6+ builds, so PBKDF callers don’t need to manually include fips.h to reach the _fips redirections.
Changes:
- Add a conditional
#include <wolfssl/wolfcrypt/fips.h>inpwdbased.hwhenFIPS_VERSION3_GE(6,0,0)is true.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lealem47
force-pushed
the
pwdbased_fips
branch
from
September 1, 2026 01:01
0500c1a to
342698b
Compare
Contributor
Author
|
Jenkins Retest this Please. |
lealem47
force-pushed
the
pwdbased_fips
branch
from
September 1, 2026 16:08
342698b to
623c13f
Compare
Contributor
Author
|
Jenkins Retest this Please. |
philljj
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redirect PBKDF API's to _fips versions without requiring a manual fips.h include
Testing
Make check
Checklist