Skip to content

Deduplication and type checking - #1159

Open
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:followup-review-findings
Open

Deduplication and type checking#1159
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:followup-review-findings

Conversation

@stenslae

Copy link
Copy Markdown
Member
  • Added authorized_key type checking extract the embedded key type directly from the SSH wire-format blob rather than using wolfSSH_QueryKey().
  • Added a makeKey function pointer to CompositeTradOps.
  • Deduplicated ECDSA Encoding
  • Introduced WOLFSSH_MLDSA_COMPOSITE_ID_CASES for redundant switch cases.
  • Centralized maximum public key sizing behind a new WOLFSSH_MLDSA_MAX_PUB_KEY_SZ macro
  • Switched to dynamically allocating MlDsaKey and large public key buffers in wolfSSH_MakeMlDsaCompositeKey() and GetOpenSshKeyMlDsaComposite() when WOLFSSH_SMALL_STACK is defined.
  • Added test coverage

@stenslae stenslae self-assigned this Aug 11, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/internal.c
Comment thread src/ossh.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/auth.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/auth.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread src/ossh.c
Comment thread src/internal.c
@stenslae
stenslae force-pushed the followup-review-findings branch from fc3c6e8 to 8000746 Compare August 12, 2026 16:13

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 7
7 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/auth.c Outdated
Comment thread tests/unit.c
Comment thread src/keygen.c
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 8000746 to 818f77b Compare August 12, 2026 21:02
Comment thread apps/wolfsshd/auth.c Outdated
Comment thread tests/unit.c
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread src/keygen.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/test/test_configuration.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 818f77b to 6f506d2 Compare August 12, 2026 22:48

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread src/internal.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/auth.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 6f506d2 to 0e54524 Compare August 31, 2026 18:06
Comment thread apps/wolfsshd/auth.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread src/internal.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs
Failed targets: wolfssh-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: none
Failed targets: wolfssh-bugs, wolfssh-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants