Deduplication and type checking - #1159
Conversation
stenslae
commented
Aug 11, 2026
- Added authorized_key type checking extract the embedded key type directly from the SSH wire-format blob rather than using wolfSSH_QueryKey().
- Added a makeKey function pointer to CompositeTradOps.
- Deduplicated ECDSA Encoding
- Introduced WOLFSSH_MLDSA_COMPOSITE_ID_CASES for redundant switch cases.
- Centralized maximum public key sizing behind a new WOLFSSH_MLDSA_MAX_PUB_KEY_SZ macro
- Switched to dynamically allocating MlDsaKey and large public key buffers in wolfSSH_MakeMlDsaCompositeKey() and GetOpenSshKeyMlDsaComposite() when WOLFSSH_SMALL_STACK is defined.
- Added test coverage
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
fc3c6e8 to
8000746
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 7
7 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
8000746 to
818f77b
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
818f77b to
6f506d2
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
6f506d2 to
0e54524
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs
Failed targets: wolfssh-src
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: none
Failed targets: wolfssh-bugs, wolfssh-src
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1159
Scan targets checked: wolfssh-bugs, wolfssh-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.