Skip to content

Remove the unstable encodings feature - #9710

Open
robert3005 wants to merge 3 commits into
developfrom
rk/remove-unstable-encodings
Open

Remove the unstable encodings feature#9710
robert3005 wants to merge 3 commits into
developfrom
rk/remove-unstable-encodings

Conversation

@robert3005

@robert3005 robert3005 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

unstable_encodings was only ever necessary to let us try things out without immediately introducing stability guarantees. We have editions now, that's the way things should be restricted, not via compile flags

@codspeed-hq

codspeed-hq Bot commented Sep 1, 2026

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 2208 untouched benchmarks
⏩ 164 skipped benchmarks1
🗄️ 1 archived benchmark run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation random_i8[0.5] 66.2 µs 90.6 µs -26.94%
Simulation decompress[u64, (4000, 1024)] 69.8 µs 85.6 µs -18.4%
Simulation random_i8[0.8] 97.5 µs 68.8 µs +41.57%
WallTime words_gather_dispatch_avx512[1024] 9 ns 7 ns +28.57%
Simulation allocate_drop_bytes[0] 520.2 ns 466 ns +11.62%
WallTime mul_u32_nonnull_avx512 6.3 µs 5.6 µs +11.46%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/remove-unstable-encodings (b599fdd) with develop (98dd977)3

Open in CodSpeed

Footnotes

  1. 164 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 1 benchmark was run, but is now archived. If it was deleted in another branch, consider rebasing to remove it from the report. Instead if it was added back, click here to restore it.

  3. No successful run was found on develop (792cef7) during the generation of this report, so 98dd977 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005
robert3005 force-pushed the rk/remove-unstable-encodings branch from 2649c0b to 7102677 Compare September 1, 2026 00:36
@robert3005 robert3005 added the changelog/break A breaking API change label Sep 1, 2026
@robert3005
robert3005 force-pushed the rk/remove-unstable-encodings branch 3 times, most recently from 82cdf1c to 9db048d Compare September 1, 2026 01:52
Base automatically changed from rk/immutableeditionevolution to develop September 2, 2026 14:17
@robert3005
robert3005 force-pushed the rk/remove-unstable-encodings branch from 9db048d to 08bcf78 Compare September 2, 2026 15:55
Use enabled editions to filter the default writer and golden compressor configurations.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/remove-unstable-encodings branch from 08bcf78 to b599fdd Compare September 2, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant