Refactor condition checks for global variables - #5405
Closed
MaddipatlaChetan24 wants to merge 1 commit into
Closed
Conversation
MaddipatlaChetan24
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 2, 2026 13:01
|
|
Collaborator
|
Looks like a duplicate of #5409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the two separate
path.parent.type === '...'checks in theIdentifiervisitor into a singleparentTypelookup compared againstboth target values. This avoids a redundant property access on the
Babel NodePath for
MemberExpression/ClassMethodparent checks.No behavioral change — same nodes are skipped as before.
Scope
Patch: Bug Fix