Fix SelectingIpDatagramSocket option and close handing - #3764
Open
reardonj wants to merge 5 commits into
Open
Conversation
Some UDP socket options (eg. SO_REUSEPORT) must be set before the socket is bound to a port. `SelectingIpDatagramSocketsProvider` was waiting until after bind to set options, making these options ineffective. All options can be set before binding, so we just need to move up the setOptions before the bind.
Duplicate the wait logic from SelectingIpSocketsProvider for UDP as well, so we wait for the socket to be unregistered, as the socket will not actually be available for reuse until after this. Note: It may still be unavailable at the operating system level, so it is best to also use the SO_REUSEADDR option (`SocketOption.reuseAddress(true)`) if you really want to close and reopen a UDP socket immediately
UDP is supported on JVM and JS.
reardonj
force-pushed
the
3762-datagram-not-closed
branch
from
September 3, 2026 15:11
2bc3021 to
5ef9823
Compare
JS does not support socket options, so we can't add the option to reuse the port, a whick point the OS may fail to release it in a timely fashion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with SelectingIpDatagramSockets from #3762:
SelectingIpDatagramSocketsProviderwas waiting until after bind to set options, making these options ineffective. All options can be set before binding, so we just need to move up the setOptions before the bind.whileM_instead of an explicit tailrec loop. Note: It may still be unavailable at the OS level, so it is best to also use the SO_REUSEADDR option (SocketOption.reuseAddress(true)) if you really want to close and reopen a UDP socket immediately.