feat: add C implementation for blas/ext/base/ndarray/dtril - #14860
feat: add C implementation for blas/ext/base/ndarray/dtril#14860ujjwalv01 wants to merge 2 commits into
blas/ext/base/ndarray/dtril#14860Conversation
c5aab9e to
ca1c1d3
Compare
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@ujjwalv01 Is this a duplicate of #14471? |
|
Oops, yes it is! Completely missed that one. Closing this PR in favor of #14471. Thanks! |
|
Hi @ujjwalv01, I was curious on your take on this package so I went ahead and took a look at the PR. I noticed you opted to pass k as a scalar in favour of keeping |
|
@Arjan-P , Thanks for taking a look and for the pointer to #14471 , It’s definitely helpful to see the discussion there. |
|
In this case, it is not clear that Whatever path we choose, we should be consistent. Given that the C API expects an array of ndarrays, it is not clear that we should be unwrapping in JS and then passing down. Instead, from JS, we should be passing the zero-dimensional ndarray. |
Resolves a part of #14819
Description
This pull request:
dtril).test.js,test.main.js,test.native.js) and benchmarks to cover and utilize the new native C addon.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted an AI assistant to help structure and generate the test files (
test.main.js,test.native.js) and benchmark files required to test the native C addon. The core logic and implementation were authored manually by myself.@stdlib-js/reviewers