Skip to content

test: migrate stats/base/dists/cosine/cdf to ULP-based assertions - #14859

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-stats-base-dists-cosine-cdf
Draft

test: migrate stats/base/dists/cosine/cdf to ULP-based assertions#14859
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-stats-base-dists-cosine-cdf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates stats/base/dists/cosine/cdf test files from the old computed EPS-based tolerance idiom (delta/tol with manual abs() comparisons) to ULP-based assertions using @stdlib/assert/is-almost-same-value.
  • updates test/test.cdf.js, test/test.factory.js, and test/test.native.js. test/test.js was not touched, as it only contains basic export-shape assertions and does not use the tolerance idiom.
  • the tightest ULP bound was determined agentically by running the full fixture set (positive_mean, negative_mean, large_variance) against the implementation and computing, for each fixture entry, the minimum ULP distance between the actual and expected values, then taking the maximum across all entries. The measured minimum is 1 ULP for all three fixture sets (and for both the main and factory code paths, which share the same underlying implementation). The test suite was run twice at this bound to confirm deterministic results.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code, running as an unattended scheduled task, following the conversion idiom established by prior merged PRs referencing #11352.


@stdlib-js/reviewers


Generated by Claude Code

Replace the computed EPS-based tolerance checks in `test.cdf.js`,
`test.factory.js`, and `test.native.js` with `isAlmostSameValue`
assertions using a measured tolerance of 1 ULP.

Ref: #11352

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Aug 31, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cosine/cdf $\\color{green}295/295$
$\\color{green}+100.00\\%$
$\\color{green}33/33$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}295/295$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue)

3 participants