test: migrate stats/base/dists/cosine/cdf to ULP-based assertions - #14859
test: migrate stats/base/dists/cosine/cdf to ULP-based assertions#14859Planeshifter wants to merge 1 commit into
stats/base/dists/cosine/cdf to ULP-based assertions#14859Conversation
Replace the computed EPS-based tolerance checks in `test.cdf.js`, `test.factory.js`, and `test.native.js` with `isAlmostSameValue` assertions using a measured tolerance of 1 ULP. Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves #11352.
Description
This pull request:
stats/base/dists/cosine/cdftest files from the old computed EPS-based tolerance idiom (delta/tolwith manualabs()comparisons) to ULP-based assertions using@stdlib/assert/is-almost-same-value.test/test.cdf.js,test/test.factory.js, andtest/test.native.js.test/test.jswas not touched, as it only contains basic export-shape assertions and does not use the tolerance idiom.positive_mean,negative_mean,large_variance) against the implementation and computing, for each fixture entry, the minimum ULP distance between the actual and expected values, then taking the maximum across all entries. The measured minimum is 1 ULP for all three fixture sets (and for both themainandfactorycode paths, which share the same underlying implementation). The test suite was run twice at this bound to confirm deterministic results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, running as an unattended scheduled task, following the conversion idiom established by prior merged PRs referencing #11352.
@stdlib-js/reviewers
Generated by Claude Code