Skip to content

Add support for YLTD001-003 and similar - #14

Open
jess-sys wants to merge 7 commits into
skorokithakis:masterfrom
jess-sys:master
Open

Add support for YLTD001-003 and similar#14
jess-sys wants to merge 7 commits into
skorokithakis:masterfrom
jess-sys:master

Conversation

@jess-sys

@jess-sys jess-sys commented Mar 9, 2021

Copy link
Copy Markdown

Adding support for amps like the Screenbar (YLTD001-003).

They support commands with the bg_ prefix for all commands.

@skorokithakis

Copy link
Copy Markdown
Owner

This is generally desirable functionality, but this PR isn't very clean (it even changes the name of the repo and removes the images). I'm also not sure about duplicating every method and adding one starting with bg_, versus adding a bg=True argument to each function (or something similar).

@skorokithakis

Copy link
Copy Markdown
Owner

Also, we can't merge a PR here, as this repo's canonical URL is https://gitlab.com/stavros/python-yeelight/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants