fix(slack): paginate v2 conversation listing - #7396
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR moves Slack conversation listing behind the registered internal-operation boundary and adds bounded cursor pagination.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported optional-pagination issue is fixed for both block-mapped and direct internal-operation inputs.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/internal/slack/operations/list-conversations.ts | Implements bounded multi-page Slack conversation retrieval, strict response validation, cursor-loop detection, and correct optional-value defaults. |
| apps/sim/blocks/blocks/slack.ts | Exposes and maps the new pagination controls while normalizing cleared optional values before execution. |
| apps/sim/tools/slack/list_channels.ts | Converts channel listing to a registered internal tool operation and expands its input and output contracts. |
| apps/sim/lib/internal/slack/execute-tool.ts | Dispatches Slack channel listing through the shared internal-operation execution boundary. |
| apps/sim/tools/slack/list_channels.test.ts | Covers short provider pages, page caps, resumable cursors, malformed responses, repeated cursors, and optional pagination defaults. |
Sequence Diagram
sequenceDiagram
participant Block as Slack v2 block
participant Tool as Internal tool boundary
participant Operation as List conversations operation
participant Slack as Slack API
Block->>Tool: list_channels(limit, cursor, maxPages)
Tool->>Operation: validated input and execution context
loop Until cursor ends or maxPages reached
Operation->>Slack: conversations.list(cursor, limit)
Slack-->>Operation: channels and next_cursor
Operation->>Operation: append channels and validate cursor
end
Operation-->>Tool: channels, count, hasMore, nextCursor, pages
Tool-->>Block: structured result
Reviews (4): Last reviewed commit: "fix(slack): clarify shared pagination ou..." | Re-trigger Greptile
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
Checklist