feat(auth): bind workflow authority to runtime principals - #7351
Open
TheodoreSpeaks wants to merge 3 commits into
Open
feat(auth): bind workflow authority to runtime principals#7351TheodoreSpeaks wants to merge 3 commits into
TheodoreSpeaks wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
Contributor
Greptile SummaryThe PR binds canonical workflow execution metadata to runtime principals and carries that authority through executor JWT transport, nested execution, snapshots, and resumptions.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/api/server/routes/internal-json-route.ts | Separates executor authentication transport from the runtime principal and propagates canonical execution workspace metadata through route composition. |
| apps/sim/lib/auth/internal-delegation.ts | Revalidates active execution context and binds canonical workflow authority to runtime principals. |
| packages/auth/src/principal.ts | Extends the principal contract with validated workflow execution metadata and related resolution helpers. |
| apps/sim/executor/utils/credential-token.ts | Resolves managed credential delegation through the bound runtime principal and fails before token issuance when execution metadata is absent. |
| apps/sim/executor/handlers/credential-group/credential-group-handler.ts | Passes the executor workspace assertion into credential-group application operations. |
| apps/sim/executor/execution/snapshot.ts | Preserves runtime principal execution authority across execution snapshots and restoration. |
Sequence Diagram
sequenceDiagram
participant E as Workflow entry point
participant P as Runtime principal binding
participant X as Executor
participant R as Internal route
participant A as Application authorization
E->>P: Actor and execution metadata
P->>P: Bind canonical workflow and workspace
P->>X: Runtime principal
X->>R: Executor JWT and execution authority
R->>R: Validate transport and canonical workspace
R->>A: Principal and asserted workspace
A-->>R: Authorized result or fail closed
Reviews (3): Last reviewed commit: "fix(auth): enforce canonical execution s..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 183 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist