hack(process/linux): enable RUSTUP_PERMIT_COPY_RENAME by default on CI - #5045
Merged
Merged
Conversation
rami3l
marked this pull request as ready for review
September 1, 2026 16:39
ChrisDenton
reviewed
Sep 1, 2026
Member
|
We should also consider doing a similar thing for |
rami3l
force-pushed
the
hack/linux-docker-copy-rename-ci
branch
from
September 2, 2026 07:39
f9871e5 to
1707932
Compare
Member
Author
@ChrisDenton Do you want me to do this in the same PR or in a subsequent one? It should be a good fit either way. |
ChrisDenton
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the concern raised in #5011 (comment). Mitigates:
rustup updatein the Rustdevcontainer(due to OverlayFS restrictions?) #4198Background
One of the many cases where OverlayFS can break rustup's transactional semantics is when rustup is used in a CI environment conveniently placed in Docker containers, where
RUSTUP_PERMIT_COPY_RENAME=1has been proven to be a viable workaround (#2949 (comment), dtolnay/rust-toolchain#177).Proposed Solution
This PR automatically enables
RUSTUP_PERMIT_COPY_RENAMEwhenCI=1.The rationale is that Linux CI machines are quite common and wasting some disk spaces there should be more or less acceptable as long as more CI workflows pass. Hopefully, by limiting the hack to CI machines, this won't have a surprisingly large burst ratio.