feat(config)!: use unqualified names for dir override - #5044
Merged
Conversation
Member
Author
|
@djc Would you mind having a look at this? Many thanks :) |
djc
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares for #2868.
Previously, when reading from
settings.toml, rustup accepts both qualified and unqualified toolchain names for dir overrides, howeverrustup override setonly writes qualified names.Essentially, this will case the same confusion as we have already had in #3651 where the user might tend to think that they have only pinned the channel with
rustup override set nightly, but in reality the host tuple at that time has also been recorded.This PR ensures the following user journey by mirroring the implementation of #4947:
rustup override set nightly.nightlywith the new default host tuple.And the impact analysis from #4947 (comment) still applies, so I'll quote it below:
PS: This change is also required for
rustup toolchain pinto get the right value for dir overrides in #5042. Otherwise, we can only get a fully qualified toolchain name because that's the value it fetches fromsettings.toml, which means--qualifywill behave differently just for dir overrides.