Update the default Windows SDK version - #4542
Merged
Merged
Conversation
This is a temporary fix for rust-lang#4446.
djc
approved these changes
Oct 17, 2025
Contributor
|
I'm fine with this change but have no particular expertise in Windows SDK, so trusting your judgement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround for #4446. The problem with the installer is that the version of the SDK we requested was removed due to security issues. Since a new rustup release is near, this PR simply changes to a version that is available as a temporary workaround. It does not fix the underlying problem (that of SDKs potentially being removed) but that is a very unusual scenario so hopefully this will be good enough for the short term.
In any case, Visual Studio 2026 is set for release very soon so I'd rather wait for that before figuring out what to do in the long term.