Add llubi to llvm-tools - #161603
Merged
Merged
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
This builds locally, so let's see: |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 23, 2026
Add llubi to llvm-tools
This comment has been minimized.
This comment has been minimized.
Contributor
saethlin
marked this pull request as ready for review
August 30, 2026 22:24
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Mark-Simulacrum
requested changes
Aug 30, 2026
| continue; | ||
| } | ||
| // On older LLVM versions, llubi isn't in the default tools. Remove this | ||
| // code when LLVM 23 is the minimum version. |
Member
There was a problem hiding this comment.
Can you bump src/bootstrap/download-ci-llvm-stamp to get the llubi binary included in download-ci? I think otherwise this is not going to take effect immediately and we'll get the does not exist warning logged in ~all builds?
rustbot
added
S-waiting-on-author
Member
Author
|
@bors r=Mark-Simulacrum |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #161603 - saethlin:dist-llubi, r=Mark-Simulacrum Add llubi to llvm-tools llubi is a tool that should be very useful when investigating problems with LLVM, because like Miri it is supposed to tell you if executing some LLVM IR encounters UB (with usual caveats). (and also clean up comments on adjacent tools)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llubi is a tool that should be very useful when investigating problems with LLVM, because like Miri it is supposed to tell you if executing some LLVM IR encounters UB (with usual caveats).
(and also clean up comments on adjacent tools)