Order grammar summary deterministically - #2346
Merged
Merged
Conversation
In `load_grammar`, we were walking files in directory-entry order. This may not be the same order in two places, leading to sections and rules sorted in different orders in the grammar summary. Let's sort by file name so as to produce deterministic results.
rustbot
added
the
S-waiting-on-review
traviscross
enabled auto-merge
August 31, 2026 07:41
traviscross
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
load_grammar, we were walking files in directory-entry order. This may not be the same order in two places, leading to sections and rules sorted in different orders in the grammar summary. Let's sort by file name so as to produce deterministic results.