WIP: Implement username changes via API - #14088
Draft
avirshup wants to merge 3 commits into
Draft
Conversation
avirshup
force-pushed
the
implement_username_updates
branch
2 times, most recently
from
June 28, 2026 20:36
2e078f6 to
59287f2
Compare
This comment has been minimized.
This comment has been minimized.
avirshup
force-pushed
the
implement_username_updates
branch
2 times, most recently
from
July 13, 2026 21:39
ec5d41f to
1bed464
Compare
This comment has been minimized.
This comment has been minimized.
avirshup
force-pushed
the
implement_username_updates
branch
from
August 7, 2026 23:50
1bed464 to
6e96b3c
Compare
avirshup
force-pushed
the
implement_username_updates
branch
from
August 8, 2026 00:04
6e96b3c to
30d2e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Updated 8/7/26)
This PR updates the
PUT /api/v1/users/{user}route to allow username changes, subject to several validation checks. This is the second PR (out of 2) for issue #13766 - it's stacked on top of the changes in #14069 (so that PR's changes will also show up in this one's diffs).Because the validation checks will need to be reused in #13768, the validation functions are implemented as a helper in
crate::controllers::helpers::username::check_username().This is still marked as "WIP" because there's still discussion on exactly how to deploy this in relation to the other username-related issues.
Please also note that, as implemented right now, the
PUT /api/v1/users/{user}call can partially succeed - e.g., the username change could succeed but the email change could fail, and the user would just get the error response from the email failure.