Skip to content

Fix href and title in rss link tags - #4001

Merged
JuanitoFatas merged 1 commit into
ruby:masterfrom
znz:fix-rss-link-tag
Sep 2, 2026
Merged

Fix href and title in rss link tags#4001
JuanitoFatas merged 1 commit into
ruby:masterfrom
znz:fix-rss-link-tag

Conversation

@znz

@znz znz commented Sep 2, 2026

Copy link
Copy Markdown
Member

For example in /en/index.html:

before:
<link href="" rel="alternate" title="" type="application/rss+xml">

after:
<link href="/en/feeds/news.rss" rel="alternate" title="Recent News (RSS)" type="application/rss+xml">

@znz
znz requested a review from a team as a code owner September 2, 2026 07:32

@JuanitoFatas JuanitoFatas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

Build comparison (two full jekyll build --future runs, master's include vs the PR's):

┌────────┬───────────────────────────────────────────────────────────────────────────┐
│        │                              rss <link> tags                              │
├────────┼───────────────────────────────────────────────────────────────────────────┤
│ before │ 7490 × <link href="" rel="alternate" title="" type="application/rss+xml"> │
├────────┼───────────────────────────────────────────────────────────────────────────┤
│ after  │ 7490 populated, 0 with href=""                                            │
└────────┴───────────────────────────────────────────────────────────────────────────┘

Thank you!

@JuanitoFatas
JuanitoFatas merged commit 5ca71ad into ruby:master Sep 2, 2026
1 check passed
@znz
znz deleted the fix-rss-link-tag branch September 3, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants