atomic_writer tiny cleanups - #9807
Merged
Merged
Conversation
Since the base `string` is a valid encoding, there should be no other invalid sequences in `sliced`.
Operations on an already open file are faster and safer than those based on the path name.
hsbt
reviewed
Aug 25, 2026
| if string.valid_encoding? | ||
| sliced = sliced.byteslice(0, sliced.bytesize - 1) until sliced.valid_encoding? | ||
| end | ||
| sliced.scrub!("") if string.valid_encoding? |
Member
There was a problem hiding this comment.
scrub!("") raises Encoding::CompatibilityError for ASCII-incompatible encodings (e.g. UTF-16LE), even when the string is fully valid, because the replacement literal is UTF-8 under frozen_string_literal.
The previous loop handled those encodings gracefully.
A UTF-8 replacement makes String#scrub! raise Encoding::CompatibilityError on an ASCII-incompatible receiver such as UTF-16LE, where the loop trimmed the tail fine. It is also slower than the loop for the common case of an ASCII name that needs no truncation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
|
I dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Trivial performance improvements.
What is your fix for the problem, implemented in this PR?
String#scrub!.Make sure the following tasks are checked