Remove temporary files after interrupted atomic saves - #63
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete the temporary file when an atomic save raises Interrupt or another Exception outside StandardError, while preserving the original failure and store contents.
Reproduction and verification
Injected IOError and Interrupt during temporary-file writes. Both must propagate, leave the old store value intact and remove temporary files. Existing code leaves a temporary file behind for Interrupt.
RBENV_VERSION=4.0.6 rbenv exec rake test: 13 tests / 26 assertions, zero failures before and after.Breaking-change notes and limitations
No normal-output or format change. Cleanup is attempted before propagating the exception. No guarantee is made for process termination, power loss or arbitrary asynchronous termination at every instruction.