Do not treat truncated read-only stores as empty files - #59
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only treat EOFError as a new empty store when the file is actually empty. A truncated Marshal stream currently appears to be an empty store in read-only transactions.
Reproduction and verification
Checked every nonempty prefix of a small Marshal store, plus a truly empty file. Truncated prefixes must be rejected; an empty file must remain a valid empty store.
RBENV_VERSION=4.0.6 rbenv exec rake test: 13 tests / 26 assertions, zero failures before and after.Breaking-change notes and limitations
Read-only callers now receive the underlying EOFError for truncated nonempty data instead of silently receiving an empty store. Genuine empty/missing read-only stores retain their behavior.