Normalize path-like objects before retaining the store filename - #58
Open
OskarEichler wants to merge 2 commits into
Open
Normalize path-like objects before retaining the store filename#58OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the retained filename with File.path. PStore accepts path-like inputs, but a File object is interpolated as its object representation during atomic saving, and path does not return the documented string.
Reproduction and verification
String, Pathname and open File inputs were checked for string path return and ultra_safe write/read round trips. The File input fails its atomic save before this correction.
RBENV_VERSION=4.0.6 rbenv exec rake test: 13 tests / 26 assertions, zero failures before and after.Breaking-change notes and limitations
Path-like inputs are normalized to strings. Existing String inputs retain their value and behavior; no path freezing or global path-policy change.