Require the current transaction owner for store operations - #57
Open
OskarEichler wants to merge 2 commits into
Open
Require the current transaction owner for store operations#57OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check Mutex#owned? instead of locked? before store operations. A second thread currently reads/writes a transaction it does not own and can change its abort flag.
Reproduction and verification
Hold a transaction in thread A, then call [], fetch, []=, delete, keys, key?, commit and abort from thread B. All must raise PStore::Error, and A must still commit its original value. Both thread_safe settings are covered using bounded queue synchronization.
RBENV_VERSION=4.0.6 rbenv exec rake test: 13 tests / 26 assertions, zero failures before and after.Breaking-change notes and limitations
Cross-thread calls outside their own transaction now raise the documented not-in-transaction error. Legitimate owner access and serialized transaction calls remain supported.