Run codegen for formatted native component calls - #58257
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The source-optimized preset enables native component codegen only when
codegenNativeComponentis immediately followed by<. Valid Flow syntax permits comments or whitespace before the type arguments, socodegenNativeComponent /* comment */ <NativeProps>(...)bypasses codegen and emits an ordinary runtime call instead of the generated__INTERNAL_VIEW_CONFIGproduced by the full preset path.Use the stable
codegenNativeComponentidentifier token as the cheap source prefilter while retaining the existing null/undefined full-scan path. Formatting no longer changes build output; false-positive tokens only enable the codegen visitor, which remains a no-op without a matching call.Changelog:
[GENERAL] [FIXED] - Run native component codegen when Flow type arguments are separated by trivia.
Test Plan:
<NativeProps>.__INTERNAL_VIEW_CONFIG; the fixed transform generates the static view config.git diff --checkpass.No public API or breaking behavior change; optimized and full preset paths now agree for valid formatting.