Lower generators in Hermes development profiles - #58255
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Hermes stable/canary development profiles intend to lower generators for debugger compatibility, but
enableRegeneratoris currently passed only to@babel/plugin-transform-runtime. That replaces runtime references but does not lower generator syntax, so dev output still contains nativefunction*declarations.Run
@babel/plugin-transform-regeneratorexplicitly for those development profiles. Async and destructuring preservation experiments take precedence: standalone regenerator otherwise overrides preserved async syntax and crashes on generator-local destructuring when runtime helpers are disabled.Changelog:
[INTERNAL] [FIXED] - Lower generators in Hermes development profiles while respecting syntax-preservation experiments.
Test Plan:
@babel/runtime/regenerator; exact baseline retainsfunction*.git diff --checkpass.Compatibility / breaking changes
Development transform output intentionally changes to match the preset's existing debugger-compatibility policy. Production output and explicit async/destructuring preservation behavior are unchanged; there is no public API break.