Inline the last duplicate Platform.select key - #58249
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
robhogan
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The React Native Babel preset statically replaces
Platform.select({...})for the target platform. Its property scan currently stops at the first matching key, while JavaScript object-literal evaluation keeps the last duplicate definition. For example,Platform.select({ios: 1, ios: 2})runs as2but the preset compiles it to1.Scan the already-validated static properties from the end so compiled output matches runtime semantics while preserving O(n), allocation-free lookup. Metro has a parallel transform that can run first; companion Metro PR #1889 applies the same correction so output remains transform-order independent.
Changelog:
[GENERAL] [FIXED] - Inline the last duplicate key from static Platform.select object literals.
Test Plan:
const value=1, while the fix emitsconst value=2.git diff --checkpass.No behavior changes for object literals without duplicate static keys; no UI change.