Support in/not in tests on sys.platform - #21913
Merged
Merged
Conversation
This is proposed for the spec in python/typing#2173. It is trivial to support in mypy and seems useful, so let's add it.
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Aug 31, 2026
|
|
||
|
|
||
| def contains_tuple_or_set_of_strings(expr: Expression) -> tuple[str, ...] | None: | ||
| if isinstance(expr, (TupleExpr, SetExpr)) and all( |
Collaborator
There was a problem hiding this comment.
why not have ListExpr
the related test is confusing, would be clearer as cast(list[str], []) or inside a function
Member
Author
There was a problem hiding this comment.
Why not, I'll add it
Member
Author
There was a problem hiding this comment.
Also, not sure what related test you're referring to?
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: meson (https://github.com/mesonbuild/meson)
+ mesonbuild/utils/platform.py:134: error: Unused "type: ignore" comment [unused-ignore]
|
hauntsaninja
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is proposed for the spec in python/typing#2173. It is trivial to support in
mypy and seems useful, so let's add it.