gh-155742: Add support.built_with_c_assertions() - #156776
Merged
Merged
Conversation
--with-assertions implies -DNDEBUG anyway. Moreover, the test is wrong for --with-assertions=no.
Member
Author
It's unlikely, but if someone uses this option, the test is wrong. Well, checking for |
StanFromIreland
approved these changes
Sep 1, 2026
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
LGTM, just two little nits.
|
|
||
|
|
||
| def built_with_c_assertions(): | ||
| # Check if Python was built with C assertions (assert()) |
Member
There was a problem hiding this comment.
Suggested change
| # Check if Python was built with C assertions (assert()) | |
| """Check if Python was built with C assertions (assert()).""" |
| # Check if Python was built with C assertions (assert()) | ||
|
|
||
| if MS_WINDOWS: | ||
| # On Windows, rely on Py_DEBUG macro to check for assertions |
Member
There was a problem hiding this comment.
Suggested change
| # On Windows, rely on Py_DEBUG macro to check for assertions | |
| # On Windows, rely on the Py_DEBUG macro to check for assertions |
Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.