gh-156693: correct complex powers with infinite bases - #156694
Open
skirpichev wants to merge 2 commits into
Open
gh-156693: correct complex powers with infinite bases#156694skirpichev wants to merge 2 commits into
skirpichev wants to merge 2 commits into
Conversation
Now we raise OverflowError's only if infinite result (i.e. cmath.isinf(result) is True) come from finite input. As proposed in issue python#156145, we don't use platforms `errno` to manage exceptions anymore. This patch also adds private API functions `_Py_c_isnan()`, `_Py_c_isinf()` and `_Py_c_isfinite()`.
Member
Author
|
CC @hpkfft |
skirpichev
commented
Aug 31, 2026
Comment on lines
342
to
351
| @@ -332,8 +349,25 @@ _Py_c_pow(Py_complex a, Py_complex b) | |||
| } | |||
| r.real = len*cos(phase); | |||
| r.imag = len*sin(phase); | |||
Member
Author
There was a problem hiding this comment.
BTW, this generic code should handle special cases above correctly. Maybe we should drop them?
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we raise OverflowError's only if infinite result (i.e. cmath.isinf(result) is True) come from finite input. As proposed in issue #156145, we don't use platforms
errnoto manage exceptions anymore.This patch also adds private API functions
_Py_c_isnan(),_Py_c_isinf()and_Py_c_isfinite().