gh-92041: Avoid a second sys.modules scan in inspect.getmodule - #156685
Open
eendebakpt wants to merge 2 commits into
Open
gh-92041: Avoid a second sys.modules scan in inspect.getmodule#156685eendebakpt wants to merge 2 commits into
eendebakpt wants to merge 2 commits into
Conversation
Pass the filename to getabsfile() explicitly, so that computing the cache key does not recurse into getmodule() through the loader check in getsourcefile(). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A frame whose filename belongs to a zipimported module must resolve through the filename fallback so getsource() can use the module's loader. Test adapted from PR python#92042. Co-authored-by: Mike Decker <mrd999@gmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
eendebakpt
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
August 30, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
inspect.getmodule()computes its filename cache key,getabsfile()consultsgetsourcefile(), which recurses intogetmodule()— scanningsys.modulesa second time on every cache miss. Cache hits also paygetsourcefile()'s linecache probe andos.path.exists()call. This PR passes the filename explicitly, so the key is computed without the recursion.Benchmark
10,000 synthetic modules in
sys.modulesBenchmark script