gh-63882: Implement empty tests in test_minidom - #156677
Open
serhiy-storchaka wants to merge 1 commit into
Open
Conversation
25 tests were defined as "def testX(self): pass" and reported success without testing anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 25 tests defined as
def testX(self): passnow testNamedNodeMapmethods, the factory methods for namespaced nodes, parsing of elements, attributes, namespaces and processing instructions, and the traversal attributes.testParseandtestParseProcessingInstructionsare limited to what is not already covered bytestParseFromBinaryFile,testParseFromTextFileandtestProcessingInstruction.This makes PR #128948, which comments these tests out, unnecessary.