Skip to content

Fix a dangling pointer and reference leak in local_timezone_from_timestamp #156598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 2 commits into from
Aug 30, 2026
+9 −4
Merged

Fix a dangling pointer and reference leak in local_timezone_from_timestamp #156598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c595424
Fix a dangling pointer and reference leak in `local_timezone_from_tim…
StanFromIreland Aug 29, 2026
24810d3
Apply Serhiy's suggestions
StanFromIreland Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6761,6 +6761,9 @@ local_timezone_from_timestamp(time_t timestamp)
struct tm local_time_tm;
PyObject *nameo = NULL;
const char *zone = NULL;
#ifndef HAVE_STRUCT_TM_TM_ZONE
char buf[100];
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated
#endif

if (_PyTime_localtime(timestamp, &local_time_tm) != 0)
return NULL;
Expand All @@ -6771,8 +6774,9 @@ local_timezone_from_timestamp(time_t timestamp)
{
PyObject *local_time, *utc_time;
struct tm utc_time_tm;
char buf[100];
strftime(buf, sizeof(buf), "%Z", &local_time_tm);
if (strftime(buf, sizeof(buf), "%Z", &local_time_tm) == 0) {
buf[0] = '\0';
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated
}
zone = buf;
local_time = new_datetime(local_time_tm.tm_year + 1900,
local_time_tm.tm_mon + 1,
Expand All @@ -6783,8 +6787,10 @@ local_timezone_from_timestamp(time_t timestamp)
if (local_time == NULL) {
return NULL;
}
if (_PyTime_gmtime(timestamp, &utc_time_tm) != 0)
if (_PyTime_gmtime(timestamp, &utc_time_tm) != 0) {
Py_DECREF(local_time);
return NULL;
}
utc_time = new_datetime(utc_time_tm.tm_year + 1900,
utc_time_tm.tm_mon + 1,
utc_time_tm.tm_mday,
Expand Down
Loading