Skip to content

Accept any sequence of header pairs, not just list #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyanu2507 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −7
Open

Accept any sequence of header pairs, not just list #204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d407ae
Type Headers as Sequence, not list
gyanu2507 Aug 29, 2026
3330d6d
Type incoming headers as Sequence, keep handshake lists as lists.
gyanu2507 Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Release History
1.4.0 (unreleased)
------------------

- Accept any sequence of ``(name, value)`` header pairs, matching ``h11``.

- Require ``event_hint`` when constructing ``RemoteProtocolError``.
This is an API-breaking change.

Expand Down
4 changes: 2 additions & 2 deletions src/wsproto/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from __future__ import annotations
from typing import Sequence

@Kriechi Kriechi Aug 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already deprecated since Python 3.9 - please use collections to import the related types. See https://docs.python.org/3/library/typing.html#deprecation-timeline-of-major-features.


Headers = list[tuple[bytes, bytes]]
Headers = Sequence[tuple[bytes, bytes]]
Loading