Add defensive check to prevent double-wrapping in spec_from_file_location wrapper - #80
Merged
Merged
Conversation
3 tasks
…tion Co-authored-by: emeryberger <1612723+emeryberger@users.noreply.github.com>
Co-authored-by: emeryberger <1612723+emeryberger@users.noreply.github.com>
emeryberger
marked this pull request as ready for review
January 27, 2026 21:45
Copilot
AI
changed the title
[WIP] Update coverage support for Alembic migrations based on review
Add defensive check to prevent double-wrapping in spec_from_file_location wrapper
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #77 to add a defensive check preventing double-wrapping of loaders when
wrap_spec_from_file_location()processes specs with already-wrapped loaders.Changes
wrap_spec_from_file_location(): Returns early ifspec.loaderis already aSlipcoverLoader, preventing nested wrapping in edge cases where an already-instrumented spec is passed through the wrappertest_wrap_spec_from_file_location_no_double_wrap()validates the defensive check by passing a wrapped loader as theloaderparameter tospec_from_file_location()The check follows the existing pattern for skipping
AssertionRewritingHookandExtensionFileLoader:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.