Ruff n ready - #932
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies code quality improvements suggested by Ruff, a Python linter and code formatter. The changes focus on simplifying code patterns and improving readability without changing functionality.
Key changes include:
- Simplified iteration patterns by removing unnecessary
.keys()calls on dictionaries - Consolidated nested if conditions into single logical expressions
- Replaced try/except blocks with
contextlib.suppress()for cleaner exception handling - Used underscore prefixes for unused loop variables
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scalene/scalene_utility.py | Simplified dictionary iteration and isinstance checks |
| scalene/scalene_profiler.py | Added warnings import, replaced print statements with warnings.warn(), consolidated nested conditions |
| scalene/scalene_nvidia_gpu.py | Replaced try/except with contextlib.suppress() for cleaner exception handling |
| scalene/scalene_neuron.py | Prefixed unused loop variables with underscores |
| scalene/scalene_leak_analysis.py | Consolidated nested if conditions into single expression |
| scalene/scalene_json.py | Simplified dictionary iteration by removing .keys() calls |
| scalene/scalene_analysis.py | Prefixed unused loop variables with underscores |
| replacement_signal_fns.py | Consolidated nested if conditions into single expression |
| replacement_poll_selector.py | Consolidated nested if conditions into single expression |
| replacement_lock.py | Added contextlib import and replaced try/except with contextlib.suppress() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made modifications in light of Ruff's analysis.