Skip to content

Ruff n ready - #932

Merged
emeryberger merged 2 commits into
masterfrom
ruff_n_ready
Aug 12, 2025
Merged

Ruff n ready#932
emeryberger merged 2 commits into
masterfrom
ruff_n_ready

Conversation

@emeryberger

Copy link
Copy Markdown
Member

Made modifications in light of Ruff's analysis.

@emeryberger
emeryberger requested a review from Copilot August 12, 2025 19:07

This comment was marked as outdated.

@emeryberger
emeryberger requested a review from Copilot August 12, 2025 20:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies code quality improvements suggested by Ruff, a Python linter and code formatter. The changes focus on simplifying code patterns and improving readability without changing functionality.

Key changes include:

  • Simplified iteration patterns by removing unnecessary .keys() calls on dictionaries
  • Consolidated nested if conditions into single logical expressions
  • Replaced try/except blocks with contextlib.suppress() for cleaner exception handling
  • Used underscore prefixes for unused loop variables

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scalene/scalene_utility.py Simplified dictionary iteration and isinstance checks
scalene/scalene_profiler.py Added warnings import, replaced print statements with warnings.warn(), consolidated nested conditions
scalene/scalene_nvidia_gpu.py Replaced try/except with contextlib.suppress() for cleaner exception handling
scalene/scalene_neuron.py Prefixed unused loop variables with underscores
scalene/scalene_leak_analysis.py Consolidated nested if conditions into single expression
scalene/scalene_json.py Simplified dictionary iteration by removing .keys() calls
scalene/scalene_analysis.py Prefixed unused loop variables with underscores
replacement_signal_fns.py Consolidated nested if conditions into single expression
replacement_poll_selector.py Consolidated nested if conditions into single expression
replacement_lock.py Added contextlib import and replaced try/except with contextlib.suppress()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scalene/scalene_nvidia_gpu.py
@emeryberger
emeryberger merged commit 30aadfd into master Aug 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants