Skip to content

Lower Python requirement to >=3.9 and verify install in conda+docker … - #71

Merged
nicovank merged 2 commits into
plasma-umass:mainfrom
tawsifazad23:feat/py39-support
Oct 8, 2025
Merged

Lower Python requirement to >=3.9 and verify install in conda+docker …#71
nicovank merged 2 commits into
plasma-umass:mainfrom
tawsifazad23:feat/py39-support

Conversation

@tawsifazad23

Copy link
Copy Markdown
Contributor

…(#66)

  • Lowered minimum Python requirement in pyproject.toml from 3.10 → 3.9
  • Verified editable install and import under:
    • Conda environment (Python 3.9) - pip install -e . succeeded; import chatdbg works
    • Docker python:3.9 image (GDB uses Python 3.13) - added /work/src to sys.path for import
  • Confirmed why executes without old_stuff.chatdbg_utils AttributeError

@nicovank

nicovank commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Thanks!

Can you also change the .github/workflows CI files to include 3.9? Other than that LGTM.

@emeryberger

Copy link
Copy Markdown
Member

Can you explain why exactly we care about 3.9 support? It's about to be end-of-life - Oct 31 2025 (see https://endoflife.date/python).

@nicovank

nicovank commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

We talked about it in person -- and I said if the fix is just lowering it in pyproject, then the cost is low and it'll fix the install for anyone still using 3.9 (IIRC Amazon / others used 3.8 a few months into the EOL date before moving to 3.10?). Seems like lowering pyproject is enough, so why not. But the moment we use a 3.10 exclusive feature we should definitely bump it back.

@tawsifazad23

Copy link
Copy Markdown
Contributor Author

Thanks!

Can you also change the .github/workflows CI files to include 3.9? Other than that LGTM.

Added Python 3.9 to CI matrices (sanity.yml and code-quality.yml).
release.yml left unchanged since it only builds/publishes under >=3.11.
All set — ready for re-review

@nicovank
nicovank merged commit 805a3d1 into plasma-umass:main Oct 8, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants