doc: document the @nodejs/doc-kit subteam - #176
Open
ovflowd wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MattIPv4
approved these changes
Aug 29, 2026
avivkeller
suggested changes
Aug 29, 2026
Comment on lines
+14
to
+18
| ### Recommendations | ||
|
|
||
| - [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. | ||
| - [ ] The **Nominee** should have any SSH or GPG key attached to their GitHub account have passphrases and/or be stored on a physical 2FA device. | ||
| - [ ] The **Nominee** should sign their Git commits. |
Member
There was a problem hiding this comment.
This is only for web-infra, right?
Member
There was a problem hiding this comment.
Everyone should be doing these things, they improve our security posture.
I think web-infra must do these things?
Member
Author
There was a problem hiding this comment.
Agree, I think we could leave as is, but also fine either removing or copy pasting this to the other team-specific recommendations.
|
|
||
| The Node.js Doc Kit Team is responsible for the day-to-day technical development of [nodejs/doc-kit](https://github.com/nodejs/doc-kit), the tooling that generates the Node.js API documentation. This covers adding features, reviewing and landing pull requests, fixing bugs and security issues, and the general maintenance of the repository. | ||
|
|
||
| The scope of this team is limited to the [nodejs/doc-kit](https://github.com/nodejs/doc-kit) repository. Members hold `Maintain` on that repository, which grants write access and the ability to manage repository settings, but **not** publishing access: ownership of the npm scopes the project publishes under, and of the Vercel project that serves [doc-kit.nodejs.org](https://doc-kit.nodejs.org/), remains with @nodejs/web-infra. Members of this team may still cut releases through the repository's automated release workflow, which publishes via npm trusted publishing. |
Member
There was a problem hiding this comment.
This paragraph as duplicative, no?
avivkeller
reviewed
Aug 29, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Aviv Keller <me@aviv.sh>
Clarified the scope and access rights of the Node.js Doc Kit Team.
bjohansebas
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We created the @nodejs/doc-kit team on GitHub so contributors to nodejs/doc-kit can be onboarded without handing them the whole Web Team surface, and the docs here never caught up. This PR documents it:
PERMISSIONS.md: new@nodejs/doc-kitcolumn. The only non-empty cell isMaintainon nodejs/doc-kit, everything else, including every external service, is-GOVERNANCE.md: new section covering the team, its scope, and its nomination process, which mirrors @nodejs/web-infraMEMBERS.md: new section, seeded with the current members of the GitHub teamonboarding/doc-kit.md: onboarding checklist, deliberately much shorter than web-infra'sREADME.md: two subteams becomes threeThe scope is intentionally narrow:
Maintainon nodejs/doc-kit and nothing else. No publishing access for now, so no 1Password vault, no Vercel, no npm scope ownership, those stay with @nodejs/web-infra. Releases still go out through the repo's automated workflow via npm trusted publishing, so this doesn't block anyone from cutting one.Heads up that touching
GOVERNANCE.mdpulls in @nodejs/tsc via CODEOWNERS. Happy to split that file into its own PR if y'all would rather land the rest first.Refs: nodejs/admin#1091