fix(agent): preserve pools with pending GOAWAY replays - #5740
Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5740 +/- ##
==========================================
- Coverage 93.47% 93.46% -0.01%
==========================================
Files 110 110
Lines 38908 38913 +5
==========================================
+ Hits 36368 36371 +3
- Misses 2540 2542 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
ronag
approved these changes
Aug 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Spurious
ClientDestroyedErrordisconnects can occur while usingfetch()withAbortSignal.timeout()against an HTTP/2 destination that sends GOAWAY.Rationale
When GOAWAY detaches an HTTP/2 session, refused requests are moved back to the Client's pending queue before a replacement connection is opened. During that window the owning Agent sees no connected or busy dispatcher and closes the Pool, despite the pending replays. Once those requests finish on the replacement Client, the closing Pool destroys it and emits an unexpected
UND_ERR_DESTROYEDdisconnect.Before this change the regression produced disconnect codes:
The second disconnect is internal cleanup rather than a request failure.
Changes
Features
N/A
Bug Fixes
fetch()requests,AbortSignal.timeout(3000), and a server-issued GOAWAY.Breaking Changes and Deprecations
N/A
Status
Validation
npm run test:h2:core— 104 passed, 2 skippednpx borp --timeout 180000 -p "test/node-test/agent.js"— 35 passednpx borp --timeout 180000 -p "test/issue-4806.js"— passednpx eslint lib/dispatcher/agent.js test/http2-goaway.js— passed