test: skip C++ symbols in tick-processor-arguments - #65906
Open
pipobscure wants to merge 1 commit into
Open
Conversation
The test only checks that a CLI flag is passed through to the V8 tick processor, but processing a --prof log makes the tick processor resolve the C++ symbols of every shared library listed in it by shelling out to nm (plus c++filt on macOS) once per library. On a --shared build that links around a hundred dylibs this takes longer than the test timeout on the macOS x86_64 GitHub Actions runner, and the outcome depends on the host toolchain rather than on node. Drop the shared-library entries from the log before processing it so the test exercises argument handling only. C++ symbol resolution is covered by test/tick-processor. Signed-off-by: Philipp Dunkel <pip@pipobscure.com>
pipobscure
force-pushed
the
tick-processor-arguments-test
branch
from
September 8, 2026 07:15
ccb5bc7 to
bdec92d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65906 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 771 771
Lines 265097 265097
Branches 50358 50355 -3
=======================================
+ Hits 239026 239031 +5
- Misses 17011 17022 +11
+ Partials 9060 9044 -16 🚀 New features to boost your workflow:
|
Contributor
|
https://github.com/nodejs/node/actions/workflows/test-shared.yml?query=is%3Afailure+is%3Atimed_out shows multiple workflows failing with timeout, for instance https://github.com/nodejs/node/actions/runs/34212576163 from @panva x86_64-darwin: with shared libraries / build: test/parallel/test-tick-processor-arguments.js#L0
Command: out/Release/node /Users/runner/work/_temp/node-v27.0.0-nightly2026-09-081b200078a0-slim/test/parallel/test-tick-processor-arguments.js
--- TIMEOUT ---so this PR does deserve attention! |
Contributor
Author
|
Can someone please request-ci for me please! |
Contributor
It needs a technical review of your PR and at least one approval before
request-ci
|
jasnell
approved these changes
Sep 8, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/parallel/test-tick-processor-argumentsonly checks that a CLI flag (--preprocess) is passed through to the V8 tick processor. Processing a--proflog, however, makes the tick processor resolve the C++ symbols of every shared library listed in the log by shelling out tonmonce per library (and, in Node's polyfill, piping the result throughc++filtagain on macOS).On the
x86_64-darwin: with shared librariesGitHub Actions job, node links roughly a hundred dylibs (V8 split into eight libraries, ~85 abseil libraries, ICU, libuv, ...), so a single--prof-processrun spawns a couple of hundred external processes on a slow Intel runner and exceeds the 120s test timeout. It has done so on unrelated PRs, e.g. https://github.com/nodejs/node/actions/runs/34138185061/job/101794526205 and https://github.com/nodejs/node/actions/runs/34169515699. The outcome of the test also depends on the host toolchain (nmavailability, Xcode license state) rather than on node itself; #50050 was a different symptom of the same dependency.This drops the
shared-library,entries from the log before handing it to--prof-process, so the test exercises argument handling only. The log remains a valid V8 log and the output is still checked to be valid JSON. C++ symbol resolution is covered by the tests intest/tick-processor.Measured locally on Linux (static build):
--prof-processnm)The SmartOS
SKIPentry inparallel.statusis left as is; I cannot verify whether the address-range problem from #50050 is confined to the shared-library lines.Refs: #50050