quic: stop guarding ngtcp2_recv_stop_sending callback field - #65688
Open
Renegade334 wants to merge 2 commits into
Open
quic: stop guarding ngtcp2_recv_stop_sending callback field#65688Renegade334 wants to merge 2 commits into
Renegade334 wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
Renegade334
force-pushed
the
quic-no-guard-required-callbacks
branch
2 times, most recently
from
August 31, 2026 16:32
5415548 to
a45f46c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65688 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01%
==========================================
Files 754 754
Lines 256395 256395
Branches 48499 48507 +8
==========================================
- Hits 230937 230935 -2
- Misses 16569 16570 +1
- Partials 8889 8890 +1 🚀 New features to boost your workflow:
|
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Renegade334
force-pushed
the
quic-no-guard-required-callbacks
branch
from
August 31, 2026 18:56
a45f46c to
69c69b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we updated ngtcp2 to v1.25, a version guard was added to the recv_stop_sending field of our ngtcp2 callbacks structs. At the time, we didn't implement it and we just passed
nullptr, so it wasn't necessary to break existing shared builds over it.Now that we have migrated to using this callback, and session functionality depends on it, we shouldn't be allowing older shared builds to omit it.
Drive-by: label the remaining omitted callbacks for ease of maintenance.