Skip to content

Let grid file names wrap onto a second line - #17541

Open
sandbranch wants to merge 1 commit into
nextcloud:masterfrom
sandbranch:grid-filename-wrap
Open

Let grid file names wrap onto a second line#17541
sandbranch wants to merge 1 commit into
nextcloud:masterfrom
sandbranch:grid-filename-wrap

Conversation

@sandbranch

Copy link
Copy Markdown

Problem

Grid labels are a single line ellipsized in the middle. On narrower cells that leaves names unreadable, and sometimes indistinguishable: two different folders in my own account both rendered as Re...es.

Fix

Allow the label a second line, so a long name wraps instead of being cut. Names that already fit keep using a single line and take no extra height, so cells with short names are unchanged.

Only grid_item.xml changes: singleLine becomes maxLines="2" and the fixed height becomes wrap_content.

Testing

Checked on a Samsung S23 and a Lenovo Tab P11 Pro (2nd gen), portrait and landscape.

Note

The bidirectional file name container in the same layout still uses a single line. Wrapping it means wrapping a name and its extension across two views, which needs more care than this change, so I left it alone rather than guess.

Grid labels were a single line ellipsized in the middle. On narrower
cells that left names unreadable and sometimes indistinguishable, with
two different folders both rendering as "Re...es".

Allow the label a second line so a long name wraps instead of being cut,
while names that fit keep using a single line and no extra height.

Signed-off-by: David Sandquist <sandquist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant