Skip to content

Fix media view not being refreshed when selecting a different media folder #17539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 2 commits into from
Sep 2, 2026
+12 −4
Merged

Fix media view not being refreshed when selecting a different media folder #17539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9342d51
Fix media view not being refreshed when selecting a different media f…
daniele-verducci Aug 31, 2026
89ae720
Documented unclear function
daniele-verducci Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions app/src/main/java/com/owncloud/android/ui/asynctasks/GallerySearchTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,24 @@ class GallerySearchTask(
private fun handleSuccess(operationResult: RemoteOperationResult<*>): Result {
val remoteFiles = operationResult.data.filterIsInstance<RemoteFile>()
val lastTimestamp = findLastTimestamp(remoteFiles)
val emptySearch = parseMedia(lastTimestamp, endDate, remoteFiles)
parseMedia(lastTimestamp, endDate, remoteFiles)
val emptySearch = remoteFiles.isEmpty()
return Result(operationResult.code, emptySearch, lastTimestamp)
}

private fun findLastTimestamp(remoteFiles: List<RemoteFile>): Long =
remoteFiles.lastOrNull()?.modifiedTimestamp?.div(MILLIS_PER_SECOND) ?: NO_TIMESTAMP

private fun parseMedia(startDate: Long, endDate: Long, remoteFiles: List<RemoteFile>): Boolean {
/**
* Sync local media files with theirs remote counterparts for the provided timespan (downloads missing,
* deletes removed ones, updates metadata).
*
* @param startDate start of timespan
* @param endDate end of timespan
* @param remoteFiles list of remote files in the folder. Only ones in the provided timespan are taken into
* consideration.
*/
private fun parseMedia(startDate: Long, endDate: Long, remoteFiles: List<RemoteFile>) {
val localFiles = storageManager.getGalleryItems(startDate * MILLIS_PER_SECOND, endDate * MILLIS_PER_SECOND)

if (BuildConfig.DEBUG) {
Expand Down Expand Up @@ -149,8 +159,6 @@ class GallerySearchTask(
" deleted: $filesDeleted unchanged: $unchangedFiles"
)
}

return filesAdded <= 0 && filesUpdated <= 0 && filesDeleted <= 0
}

private fun enrichFromLocalStorage(file: RemoteFile) {
Expand Down
Loading