Skip to content

Improve chunked upload - #17508

Merged
alperozturk96 merged 9 commits into
masterfrom
improve-chunked-upload
Sep 3, 2026
Merged

Improve chunked upload#17508
alperozturk96 merged 9 commits into
masterfrom
improve-chunked-upload

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 mentioned this pull request Aug 20, 2026
Closed
4 tasks
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32365738081/artifacts/9405404973
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
add chunked max upload size
a523780 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use user's capabilities to inject serverMaxChunkSize
481bc50 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java
@alperozturk96
update lib
38f6b11 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update lib
cf271fb 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update lib
3a3e569 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update lib
6261c23 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update lib
40b88b7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use local lib temporary
27f03e2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
revert
dc29cfa 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.0 milestone Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

daniele-verducci
daniele-verducci approved these changes Sep 1, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper, I tested:

  • file under server's advertised chunk size in normal folder
  • file over server's advertised chunk size in normal folder (uses chunked upload)
  • file under server's advertised chunk size in encrypted folder
  • file over server's advertised chunk size in encrypted folder (uses chunked upload)

Works flawlessly.

Tried to test the upload on slow connection as reported in the issue, I used the emulator's trottling, works but in that case also the current stable worked for me so not much to compare there...

Checked the code and seems nice to me.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33501940736/artifacts/9852439238
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5859
Dodgy code206207
Experimental11
Malicious code vulnerability22
Multithreaded correctness2526
Performance3739
Security1919
Total380385

SpotBugs increased!

@alperozturk96
alperozturk96 merged commit a6717a2 into master Sep 3, 2026
21 of 33 checks passed
@alperozturk96
alperozturk96 deleted the improve-chunked-upload branch September 3, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.0

Development

Successfully merging this pull request may close these issues.

Chunked upload ignores server's files.chunked_upload.max_size; uploads from slow networks fail

2 participants

@alperozturk96 @daniele-verducci