Hide the bottom navigation bar when a text file preview is shown - #17504
Conversation
| binding.fabMain.setImageResource(R.drawable.ic_plus) | ||
| resetScrolling(true) | ||
| showSortListGroup(false) | ||
| showBottomNavigationBar(true) |
There was a problem hiding this comment.
@tobiasKaminsky should I check what's the popped fragment here? I didn't because, as far as I can see, the default status is for the bottom navigation to be visible. This is similar to what happens to resetScrolling().
|
APK file: https://github.com/nextcloud/android/actions/runs/32240739106/artifacts/9360935236 |
|
APK file: https://github.com/nextcloud/android/actions/runs/32345524977/artifacts/9398145437 |
b0d9871 to
4b6963e
Compare
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/33377818879/artifacts/9752836923 |
afcb505 to
192a623
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/33496697751/artifacts/9799376666 |
…s shown Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
192a623 to
eb3964e
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/33616771100/artifacts/9842897591 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fix #17495
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)
Changes
This hides the bottom navigation bar that was covering part of a previewed text file.
How to reproduce: