Skip to content

Hide the bottom navigation bar when a text file preview is shown - #17504

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/17495
Sep 2, 2026
Merged

Hide the bottom navigation bar when a text file preview is shown#17504
alperozturk96 merged 1 commit into
masterfrom
fix/17495

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Fix #17495

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Changes

This hides the bottom navigation bar that was covering part of a previewed text file.

How to reproduce:

  • download a text file
  • open it
  • note the bottom bar over the text (on master)

@daniele-verducci daniele-verducci self-assigned this Aug 19, 2026
binding.fabMain.setImageResource(R.drawable.ic_plus)
resetScrolling(true)
showSortListGroup(false)
showBottomNavigationBar(true)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky should I check what's the popped fragment here? I didn't because, as far as I can see, the default status is for the bottom navigation to be visible. This is similar to what happens to resetScrolling().

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32240739106/artifacts/9360935236
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32345524977/artifacts/9398145437
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci marked this pull request as ready for review August 20, 2026 09:00
@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33377818879/artifacts/9752836923
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33496697751/artifacts/9799376666
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

…s shown

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.0 milestone Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5959
Dodgy code206206
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance3939
Security1919
Total383383

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33616771100/artifacts/9842897591
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 merged commit b6b4f74 into master Sep 2, 2026
19 of 23 checks passed
@alperozturk96
alperozturk96 deleted the fix/17495 branch September 2, 2026 11:06
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom menu covers file content

2 participants