Skip to content

CI: bump actions, add ubuntu 26.04, dependabot, zizmor, actionlint - #251

Merged
thaJeztah merged 6 commits into
moby:mainfrom
kolyshkin:bump-ci-actions
Sep 4, 2026
Merged

CI: bump actions, add ubuntu 26.04, dependabot, zizmor, actionlint#251
thaJeztah merged 6 commits into
moby:mainfrom
kolyshkin:bump-ci-actions

Conversation

@kolyshkin

@kolyshkin kolyshkin commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rebased on top of #250.

Bumps:

  • actions/checkout: v6.0.2 → v7.0.1
  • actions/setup-go: v6.3.0 → v7.0.0
  • codecov/codecov-action: v5.5.3 → v7.0.0
  • codespell: 2.3.0 → 2.4.3

All three action bumps are major releases, but the only user-visible change is the move to node24 (and ESM); all runners in our matrix support it.

Dependabot: adds .github/dependabot.yml for the github-actions ecosystem so the pinned digests (and their version comments) stop going stale. Updates are grouped into a single weekly PR with a 7-day cooldown. Go modules are deliberately left out — those are maintained by hand.

Hardening: sets persist-credentials: false on both actions/checkout steps; nothing in this workflow pushes back to the repo.

zizmor: adds a job running zizmor, a static analyzer for GitHub Actions workflows, so this kind of thing gets caught automatically from now on. Findings are reported as workflow annotations rather than uploaded to the security tab, so it needs no extra permissions.

actionlint: adds a separate workflow running actionlint, which validates the workflow syntax, expressions and runner labels, and runs shellcheck over the run: scripts.

ubuntu-26.04: added to the test matrix. Those runners are still in public preview; all jobs pass on them. actionlint does not know the label yet, so .github/actionlint.yaml declares it — to be dropped once an actionlint release includes it.

@kolyshkin kolyshkin changed the title CI: bump actions, add dependabot config CI: bump actions, add ubuntu 26.04, dependabot, zizmor, actionlint Aug 28, 2026
 - actions/checkout: v6.0.2 -> v7.0.1
 - actions/setup-go: v6.3.0 -> v7.0.0
 - codecov/codecov-action: v5.5.3 -> v7.0.0
 - codespell: 2.3.0 -> 2.4.3

The action bumps are major releases, but the only user-visible change
is the move to node24 (and ESM), which all the runners we use support.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Let dependabot keep the pinned action digests (and their version
comments) up to date, so they do not get stale again. Grouped into a
single PR to avoid the noise; Go modules are not included as those are
maintained manually.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
By default actions/checkout leaves the GITHUB_TOKEN in the local git
config, where any later step (or anything that archives the workspace)
can pick it up. Nothing here pushes back to the repository, so turn it
off, as suggested by zizmor's "artipacked" audit.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Add a job running zizmor, a static analyzer for GitHub Actions
workflows, to catch common CI misconfigurations and security issues
(such as the credential persistence fixed in the previous commit).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
kolyshkin marked this pull request as draft August 28, 2026 07:57
Add a workflow running actionlint, a static checker for GitHub Actions
workflow files. It complements zizmor: where zizmor looks for security
issues, actionlint validates the workflow syntax itself, the expressions
and the runner labels, and runs shellcheck over the run: scripts.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Ubuntu 26.04 runners are still in public preview, but let's start
testing on them early.

As actionlint does not know about the ubuntu-26.04 runner label yet,
add an actionlint config declaring it, to be removed once a release
with the label lands.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
kolyshkin requested a review from thaJeztah August 28, 2026 08:34
@kolyshkin
kolyshkin marked this pull request as ready for review August 28, 2026 08:35
@thaJeztah
thaJeztah requested a lite review from Copilot September 2, 2026 10:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The codespell pip install pin uses an invalid v-prefixed version spec (codespell==v2.4.3), which is likely to break the codespell job.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates and hardens the repository’s GitHub Actions CI setup by bumping major action versions (to Node 24/ESM), expanding the runner matrix, and adding automated workflow linting/scanning plus Dependabot maintenance for pinned action digests.

Changes:

  • Bump actions/checkout, actions/setup-go, and codecov/codecov-action to their latest major versions and harden checkouts with persist-credentials: false.
  • Expand the CI matrix to include ubuntu-26.04, and add a new zizmor workflow-analysis job.
  • Add a dedicated actionlint workflow and an actionlint config file; add Dependabot updates for the github-actions ecosystem.
File summaries
File Description
.github/workflows/test.yml Updates CI matrix/actions, hardens checkout, bumps Codecov/codespell, adds zizmor job.
.github/workflows/actionlint.yml Adds a workflow to run actionlint over workflows/scripts.
.github/dependabot.yml Configures Dependabot to update GitHub Actions dependencies weekly in a grouped PR.
.github/actionlint.yaml Configures actionlint to accept the ubuntu-26.04 runner label.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test.yml
@kolyshkin

Copy link
Copy Markdown
Collaborator Author

@thaJeztah PTAL

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@thaJeztah
thaJeztah merged commit 79376e0 into moby:main Sep 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants