[Open Data] Update commitment discount eligibility (September 2026) - #2299
Open
Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Open
[Open Data] Update commitment discount eligibility (September 2026)#2299Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Roland Krummenacher (RolandKrummenacher) wants to merge 1 commit into
Conversation
Roland Krummenacher (RolandKrummenacher)
requested review from
Brett Wilson (MSBrett) and
Michael Flanakin (flanakin)
as code owners
September 2, 2026 16:20
microsoft-github-policy-service
Bot
added
Needs: Review 👀
Copilot started reviewing on behalf of
Roland Krummenacher (RolandKrummenacher)
September 2, 2026 16:21
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description asserts “no meters removed” and “no eligibility flips,” but the updated CSV shows at least one meter ID missing and at least two existing meter IDs with changed eligibility, so either the data generation or the PR description needs correction.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the open data snapshot for commitment discount eligibility (generated from the Azure Retail Prices API) and refreshes associated rollup counts used for reporting/validation.
Changes:
- Adds new meter eligibility rows to
CommitmentDiscountEligibility.csv. - Updates service-family rollup counts in
CommitmentDiscountEligibility.familycounts.json. - Includes at least one removed meter ID and at least two eligibility changes for existing meter IDs, which conflicts with the PR description’s “additive-only / no flips” claims.
File summaries
| File | Description |
|---|---|
| src/open-data/CommitmentDiscountEligibility.familycounts.json | Updates rollup counts (e.g., Compute counts) to reflect the latest eligibility dataset. |
| src/open-data/CommitmentDiscountEligibility.csv | Updates the eligibility table with newly added meter IDs and other row-level changes. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated update of commitment discount eligibility data from the Azure Retail Prices API, produced by the Update Commitment Discount Eligibility workflow (run 33650494002).
Net +269 meters (92,624 → 92,893), composed of:
Resulting distribution:
The three non-additive rows, verified against the live API
All three were checked directly against
prices.azure.comwithapi-version=2023-01-01-previewandmeterRegion='primary'— the same parameters the fetch script uses.savingsPlanis only returned on that api-version, so a check without it reports no savings plan for every meter.99031618-6869-5409-9d5d-617a392fa088dc5d07a3-7915-5e95-921d-8beabf3c0c5ad0e8cf9a-e52a-5e56-ae17-318d9a1ad5c1The two VM meters gained savings plan pricing upstream, so
Eligible / Eligibleis now correct anddevis stale. The Foundry Models meter no longer has reservation or savings plan pricing, so it is eligible for neither; the script intentionally drops such meters rather than emittingNot Eligible / Not Eligible("Meters not seen this run are dropped (so retired meters age out instead of accumulating forever)"). That combination does not exist anywhere in the dataset, before or after.Notes
This run was dispatched manually rather than using the branch from the 2026-08-31 scheduled run (
opendata/commitment-eligibility-20260831-29). That branch was cut before #2284 merged, so it still carried the pre-swap column orientation and would have reverted the FOCUSCommitmentDiscountCategoryalignment across ~36k rows. It has been deleted, along with five older superseded snapshot branches.Test plan
🤖 Generated by the Update Commitment Discount Eligibility workflow