ci: enforce EditorConfig with pre-commit - #18694
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new required check has 33 baseline failures, and the remote hook should be pinned to an immutable commit SHA.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds EditorConfig enforcement for tracked TOML files using pre-commit.
Changes:
- Adds a pinned
editorconfig-checkerhook. - Runs formatting validation in CI.
- Documents local usage and hook installation.
File summaries
| File | Description |
|---|---|
.pre-commit-config.yaml |
Configures TOML checking. |
.github/workflows/lint.yaml |
Adds pre-commit validation to CI. |
CONTRIBUTING.md |
Documents the local workflow. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The description claims the check should fail, but the included baseline cleanup makes it pass.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/36 changed files
- Comments generated: 1
- Review effort level: Balanced
1f7bcf3 to
307b09a
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Touched component inputs require refreshed locks and post-commit rendered specifications to prevent release and changelog drift.
Review details
- Files reviewed: 3/36 changed files
- Comments generated: 0 new
- Review effort level: Balanced
reuben olinsky (reubeno)
left a comment
reuben olinsky (reubeno)
left a comment
There was a problem hiding this comment.
One question for you regarding GitHub action, but the rest of the PR looks great to me.
There was a problem hiding this comment.
🟡 Changes recommended
Component outputs require post-commit regeneration, and the new Python runtime should be pinned.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/38 changed files
- Comments generated: 1
- Review effort level: Balanced
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
3aecec4 to
9b623fe
Compare
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
There was a problem hiding this comment.
🟢 Approval recommended
The enforcement, documentation, dependency automation, and baseline cleanup are consistent and validated by the passing lint run.
Review details
- Files reviewed: 5/38 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Add a pinned editorconfig-checker hook and run it through pre-commit in both CI and the documented local workflow. This establishes a shared framework that can host additional repository checks later. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
726eeee to
7674ff9
Compare
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Summary
editorconfig-checkerhook through pre-commitValidation
The initial implementation intentionally left the existing TOML formatting violations unchanged. The first lint run failed with 33 errors, demonstrating that the hook detected:
A separate cleanup commit repaired those violations, and the follow-up lint run passed.
This is an alternative to #18691 for comparing direct checker integration with a reusable pre-commit framework.