fix: preserve user token namespace on refresh - #215
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
UserAccessToken.get(key, { namespace })reads from the requested namespace, but both successful recovery paths wrote the refreshed token without forwarding that namespace. The custom namespace stayed expired, so subsequent reads refreshed again and the new token was stored under the app-ID namespace.What changed
Validation
corepack yarn test --runInBand client/__tests__/user-access-token.test.ts— 2 passedcorepack yarn test --runInBand— 47 suites passed; 447 passed, 5 skippedgit diff --checkCloses #210