chore: remove dead UnionAsMapOptions fields - #42
Merged
Conversation
omit_nulls and omit_defaults were declared on UnionAsMapOptions and never read, in either direction. They are copy-paste from StructAsMapOptions, where both are genuinely used by isStructFieldUsed on the encode side. They are also meaningless here: packUnionAsMap always writes packMapHeader(writer, 1), one entry for the active variant, so there is nothing to omit. Same category as the surface removed in #27, and no behaviour change since nothing consulted them.
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.
Both are copy-paste from
StructAsMapOptions, where they are genuinely used byisStructFieldUsedon the encode side. Here nothing consults them in either direction.They are also meaningless in this position:
packUnionAsMapalways writespackMapHeader(writer, 1)— one entry, the active variant — so there is nothing to omit.Same category as the dead surface removed in #27. No behaviour change, since nothing read them.
Breaking only for code that set them explicitly, which could only ever have been a no-op. Recorded in the changelog under Removed.
zig build test: 183/183 pass.Noticed while adding
skip_unknown_fieldsin #28 and deferred to keep that PR focused.