docs(modal): reorganize Styling and add Sizing to Content section - #4689
docs(modal): reorganize Styling and add Sizing to Content section#4689brandyscarney wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| :::note | ||
| ### Styling | ||
|
|
||
| If you are building an Ionic Angular app, the styles need to be added to a global stylesheet file. Read [Style Placement](#style-placement) in the Angular section below for more information. |
There was a problem hiding this comment.
The Style Placement section has been removed since v6 so I deleted this entire note: 997fe9e
| <SheetScrollingContentExample /> | ||
|
|
||
| ## Styling | ||
| ## Theming |
There was a problem hiding this comment.
Reorganizing the sections into Theming -> Styling to match other components, see: https://ionicframework.com/docs/api/action-sheet#theming
I considered updating the playground directory structure but moving any would break the JP docs.
| <ThemeExample /> | ||
|
|
||
| ### Animations | ||
| ## Animations |
There was a problem hiding this comment.
I promoted Animations out of Theming because it doesn't actually change any styles.
There was a problem hiding this comment.
Updated older documentation so any future deployments would be accurate.
aeeb3cf to
8bc0246
Compare
8bc0246 to
80cb755
Compare
| [Controller modals](#controller-modals) are appended to the root of your application, outside of the component that presented them. Component-scoped styles will not reach these modals, so their styles must be applied globally, from a stylesheet that is not scoped to a component. | ||
|
|
||
| :::note | ||
| [Inline modals](#inline-modals-recommended) stay where they are declared in your template, so component-scoped styles do apply to them. |
There was a problem hiding this comment.
I can revert this if desired - but I don't know why inline modals were specified here as needing to be overridden globally. We can target ion-modal directly from the example component.
brandyscarney
changed the title
1 participant
Description
Sizing to Contentsection detailing how to set--heightto a content size to have the modal resize to its rendered content & added a playground exampleOther information
Previews: