Don't tolerate num_classes > kNumBaseClasses - #596
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_973710772
branch
2 times, most recently
from
August 31, 2026 16:37
055c675 to
a5ba60c
Compare
The logic behind current silent trimming of size classes array is unclear. I don't think it can lead to anything good/reasonable. Fortunately, this logic does not kick in for any of the existing classes. Replace silent trimming with loud failure. PiperOrigin-RevId: 973942307
copybara-service
Bot
force-pushed
the
test_973710772
branch
from
August 31, 2026 17:05
a5ba60c to
31a8a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't tolerate num_classes > kNumBaseClasses
The logic behind current silent trimming of size classes array is unclear.
I don't think it can lead to anything good/reasonable.
Fortunately, this logic does not kick in for any of the existing classes.
Replace silent trimming with loud failure.